made closure param mutable #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'enhancement', 'documentation', 'new feature', 'dependencies', 'internal', 'breaking-change', 'bug'} |
|
PR missing one of the required labels: {'documentation', 'dependencies', 'breaking-change', 'enhancement', 'internal', 'new feature', 'bug'} |
12 tasks
include/zenoh_commons.h
Outdated
| @@ -1927,7 +1927,7 @@ const struct z_loaned_closure_sample_t *z_closure_sample_loan(const struct z_own | |||
| #if defined(UNSTABLE) | |||
| ZENOHC_API | |||
| void z_closure_zid_call(const struct z_loaned_closure_zid_t *closure, | |||
| const z_id_t *z_id); | |||
There was a problem hiding this comment.
z_id_t is non-owned object, there is no benefit in having it non-const, also leads to questions whether the user is in the right to call free on it ?
DenisBiryukov91
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix related to eclipse-zenoh/zenoh#1372
Preparation for further making
z_takeoperation forz_loaned_xxx_t*callback parameters. This will allow user to take ownership of data passed to callback without clone operation.This update is unsafe for C++, as in the zenoh-cpp it's already possible to perform
std::moveas soon as the callback parameter is not const. But in this update this is unsafe as on the rust side the non-owned objects are actually passed to callback. I.e. on rust side it's now&mut Samplerepresented asz_loaned_sample_t*. This means that it's prohibited at this moment to convertz_loaned_sample_t*toz_owned_sample_t*(which isOption<Sample>on rust side). But zenoh-cpp is built on assumption that it's safe to do this conversion because until this moment it was not possible to getz_loaned_xxx_t*reference directly to object other thanz_owned_xxx_t.The safety correction will be made in separate update to accelerate C++ API updating and to make verifying of safety update easier